fix: json attribute error for GET with parameters #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The httpx get method does not support the json parameter, instead the params parameter has to be provided.
ehendrix23
changed the title
|
Fixed the title issue. Not sure why 3.10 failed the test as I do not see how my small change would cause it to fail. |
alandtse
changed the title
alandtse
added a commit
that referenced
this pull request
Nov 7, 2024
fix: json attribute error for GET with parameters (#477)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing an API call for which the method is get but where parameters are provided an exception occurs for unknown attribute json=data.
This is due to the httpx get method not supporting the json parameter, instead the params parameter has to be provided.
This fixed checks if the method is get and if it is will provide the additional parameters through params parameter instead.